Model translation#4582
Merged
Merged
Conversation
Goober5000
added
sexps
BMagnu
requested changes
Aug 23, 2022
BMagnu
left a comment
BMagnu
left a comment
Member
There was a problem hiding this comment.
Looks mostly good, Some questions and comments
Goober5000
force-pushed
the
model_translation
branch
from
faafa7f to
eb3d405
Compare
BMagnu
approved these changes
Aug 26, 2022
JohnAFernandez
requested changes
Aug 27, 2022
Goober5000
force-pushed
the
model_translation
branch
from
f6dd0a6 to
6772999
Compare
Contributor
Author
|
Ok, I left the comments modified but removed the multi version bump. I also rebased onto the latest master. I'll wait until the next nightly before taking this out of draft status. |
JohnAFernandez
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements model translation, including the following:
This is merely the latest step in a long line of PRs leading to this point, starting with Swifty's submodel instance refactor and continuing through my submodel overhaul PR's and Lafiel's animation PRs.
This PR is in draft status until #4560 is merged and until we can coordinate a multi version bump.